Fix ODB installation in web Docker image #756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcserep
added
Kind: Bug ⚠️
Kind: Refactor 🔃
Target: Developer environment
intjftw
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #742.
The ODB installation in the web only docker images were incorrect. While fixing this I also improved the previous approach, which made a full ODB custom compilation both for the
dev, theruntimeand thewebimages.With this PR the ODB library will be only compiled for the
devimage, and then the installation directory will be copied to theruntimeand thewebimage without recompilation. This should speed up building theruntimeand thewebimages significantly (by 20+ minutes on my machine).