Conversation
Comment on lines
+48
to
+52
| <DataGridTextColumn Header="Type" Binding="{Binding ObjectType}" Width="*" MinWidth="80" /> | ||
| <DataGridTextColumn Header="Action" Binding="{Binding UpdateAction}" Width="80" /> | ||
| <DataGridTextColumn Header="Difference" Binding="{Binding DifferenceType}" Width="80" /> | ||
| <DataGridTextColumn Header="Source" Binding="{Binding SourceObjectName}" Width="80" /> | ||
| <DataGridTextColumn Header="Target" Binding="{Binding TargetObjectName}" Width="80" /> | ||
| <DataGridTextColumn Header="Source" Binding="{Binding SourceObjectName}" Width="100" /> | ||
| <DataGridTextColumn Header="Target" Binding="{Binding TargetObjectName}" Width="100" /> |
There was a problem hiding this comment.
These hard-coded column width values (80/100/*) are effectively magic numbers and are now being adjusted in multiple places. Consider moving the widths into XAML resources (e.g., x:Double resources) or a shared style so future layout tweaks stay consistent and require fewer edits.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.