Skip to content

Remove non-visual schema compare feature#171

Merged
ErikEJ merged 3 commits intomainfrom
copilot/remove-non-visual-compare-feature
Mar 3, 2026
Merged

Remove non-visual schema compare feature#171
ErikEJ merged 3 commits intomainfrom
copilot/remove-non-visual-compare-feature

Conversation

Copy link
Contributor

Copilot AI commented Mar 3, 2026

  • Investigate the codebase to understand the non-visual compare feature
  • Remove compare command from src/DacFXTool/Program.cs
  • Remove Compare() method from src/DacFXToolLib/DacPackageComparer.cs
  • Delete src/Vsix/Commands/CompareCommand.cs
  • Delete src/Vsix/Handlers/CompareHandler.cs
  • Remove GetCompareAsync from src/Vsix/Handlers/ProcessLauncher.cs
  • Remove cmdidCompare button from src/Vsix/VSCommandTable.vsct
  • Remove cmdidCompare from src/Vsix/VSCommandTable.cs
  • Remove deleted files from src/Vsix/Vsix.csproj compile items
  • Build and verify changes
Original prompt

This section details on the original issue you should resolve

<issue_title>Remove non-visual compare feature</issue_title>
<issue_description>Including in the Vsix project and the command line tool</issue_description>

Comments on the Issue (you are @copilot in this section)


🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.

Co-authored-by: ErikEJ <4169187+ErikEJ@users.noreply.github.com>
Copilot AI changed the title [WIP] Remove non-visual compare feature from Vsix project and tool Remove non-visual schema compare feature Mar 3, 2026
@ErikEJ ErikEJ marked this pull request as ready for review March 3, 2026 09:22
Copilot AI review requested due to automatic review settings March 3, 2026 09:22
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the non-visual schema compare feature (plain SQL diff script generation) across the VSIX extension, CLI tool, and shared library, keeping the visual schema compare functionality intact.

Changes:

  • Removes the VSIX command/button and supporting handler/launcher entry point for non-visual compare.
  • Removes the CLI compare command handler block.
  • Removes the library DacPackageComparer.Compare() method and related unused imports.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/Vsix/VSCommandTable.vsct Removes the “Schema compare script...” command/button and its ID symbol.
src/Vsix/VSCommandTable.cs Removes the cmdidCompare constant from generated package IDs.
src/Vsix/Handlers/ProcessLauncher.cs Removes the GetCompareAsync() launcher method that invoked the CLI compare command.
src/DacFXToolLib/DacPackageComparer.cs Removes the non-visual Compare() API and cleans up now-unused imports.
src/DacFXTool/Program.cs Removes the CLI compare command handler block.
Comments suppressed due to low confidence (1)

src/DacFXTool/Program.cs:209

  • With the compare command removed, invoking dacfxtool compare ... will now fall through the command dispatch without printing an error and still return exit code 0. It would be better to either explicitly detect compare and return a non-zero exit code with a clear message (e.g., command removed / use visualcompare), or add a final default branch that treats unknown commands as an error.
                    // visualcompare "<DACPAC_PATH>" "connectionString" <database_is_source>
                    if (args.Length == 4
                        && args[0] == "visualcompare"
                        && bool.TryParse(args[3], out bool visualDbIsSource))
                    {

Co-authored-by: ErikEJ <4169187+ErikEJ@users.noreply.github.com>
@ErikEJ ErikEJ merged commit 9ecedbf into main Mar 3, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove non-visual compare feature

3 participants