Merged
Conversation
Co-authored-by: ErikEJ <4169187+ErikEJ@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Remove non-visual compare feature from Vsix project and tool
Remove non-visual schema compare feature
Mar 3, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the non-visual schema compare feature (plain SQL diff script generation) across the VSIX extension, CLI tool, and shared library, keeping the visual schema compare functionality intact.
Changes:
- Removes the VSIX command/button and supporting handler/launcher entry point for non-visual compare.
- Removes the CLI
comparecommand handler block. - Removes the library
DacPackageComparer.Compare()method and related unused imports.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/Vsix/VSCommandTable.vsct | Removes the “Schema compare script...” command/button and its ID symbol. |
| src/Vsix/VSCommandTable.cs | Removes the cmdidCompare constant from generated package IDs. |
| src/Vsix/Handlers/ProcessLauncher.cs | Removes the GetCompareAsync() launcher method that invoked the CLI compare command. |
| src/DacFXToolLib/DacPackageComparer.cs | Removes the non-visual Compare() API and cleans up now-unused imports. |
| src/DacFXTool/Program.cs | Removes the CLI compare command handler block. |
Comments suppressed due to low confidence (1)
src/DacFXTool/Program.cs:209
- With the
comparecommand removed, invokingdacfxtool compare ...will now fall through the command dispatch without printing an error and still return exit code 0. It would be better to either explicitly detectcompareand return a non-zero exit code with a clear message (e.g., command removed / usevisualcompare), or add a final default branch that treats unknown commands as an error.
// visualcompare "<DACPAC_PATH>" "connectionString" <database_is_source>
if (args.Length == 4
&& args[0] == "visualcompare"
&& bool.TryParse(args[3], out bool visualDbIsSource))
{
Co-authored-by: ErikEJ <4169187+ErikEJ@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
comparecommand fromsrc/DacFXTool/Program.csCompare()method fromsrc/DacFXToolLib/DacPackageComparer.cssrc/Vsix/Commands/CompareCommand.cssrc/Vsix/Handlers/CompareHandler.csGetCompareAsyncfromsrc/Vsix/Handlers/ProcessLauncher.cscmdidComparebutton fromsrc/Vsix/VSCommandTable.vsctcmdidComparefromsrc/Vsix/VSCommandTable.cssrc/Vsix/Vsix.csprojcompile itemsOriginal prompt
🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.