Added overwrite option to storage-link command (#215)

* Added overwrite option to storage-link command * fix
EscolaLMS · Nov 8, 2024 · e3e5d97 · e3e5d97
1 parent a4512fc
commit e3e5d97
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 8 deletions.
diff --git a/src/Commands/StorageH5PLinkCommand.php b/src/Commands/StorageH5PLinkCommand.php
@@ -14,7 +14,7 @@ class StorageH5PLinkCommand extends Command
      *
      * @var string
      */
-    protected $signature = 'h5p:storage-link {--relative : Create the symbolic link using relative paths}';
+    protected $signature = 'h5p:storage-link {--relative : Create the symbolic link using relative paths} {--overwrite : Overwrite files if they existed before}';
 
     /**
      * The console command description.
@@ -31,16 +31,19 @@ class StorageH5PLinkCommand extends Command
     public function handle()
     {
         $relative = $this->option('relative');
+        $overwrite = $this->option('overwrite');
 
         $links = $this->links();
 
         foreach ($links as $link => $target) {
-            if (Storage::directoryExists($link)) {
-                try {
-                    Storage::assertDirectoryEmpty($link);
-                } catch (ExpectationFailedException $e) {
-                    $this->error("The [$link] link already exists.");
-                    continue;
+            if (!$overwrite) {
+                if (Storage::directoryExists($link)) {
+                    try {
+                        Storage::assertDirectoryEmpty($link);
+                    } catch (ExpectationFailedException $e) {
+                        $this->error("The [$link] link already exists.");
+                        continue;
+                    }
                 }
             }
 

diff --git a/tests/Api/LibraryApiTest.php b/tests/Api/LibraryApiTest.php
@@ -314,8 +314,11 @@ public function test_reinstall_library_dependencies()
         $libraryDependencies = H5PLibraryDependency::where('library_id', $library->getKey());
         $libraryDependenciesCount = $libraryDependencies->count();
 
+        if ($libraryDependencies->count() > 0) {
+            $libraryDependencies->first()->delete();
 
-        $libraryDependencies->first()->delete();
+            $this->assertNotEquals($libraryDependenciesCount, $libraryDependencies->count());
+        }
 
         $this->assertNotEquals($libraryDependenciesCount, $libraryDependencies->count());