Add url to AdministrableConfig (#201)

EscolaLMS · Feb 22, 2024 · fbde2d5 · fbde2d5
1 parent 05252a3
commit fbde2d5
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 0 deletions.
diff --git a/src/Providers/SettingsServiceProvider.php b/src/Providers/SettingsServiceProvider.php
@@ -26,6 +26,7 @@ public function register()
             AdministrableConfig::registerConfig(ConfigEnum::CONFIG_KEY . '.h5p_ext_communication', ['boolean'], false);
             AdministrableConfig::registerConfig(ConfigEnum::CONFIG_KEY . '.h5p_save_content_state', ['boolean'], false);
             AdministrableConfig::registerConfig(ConfigEnum::CONFIG_KEY . '.h5p_save_content_frequency', ['numeric'], false);
+            AdministrableConfig::registerConfig(ConfigEnum::CONFIG_KEY . '.url', ['string'], false);
         }
     }
 }
diff --git a/tests/Feature/SettingsTest.php b/tests/Feature/SettingsTest.php
@@ -65,6 +65,7 @@ private function getConfig(): array
         $h5p_ext_communication = false;
         $h5p_save_content_state = false;
         $h5p_save_content_frequency = 3;
+        $h5p_url = 'h5p-test';
 
         return [
             [
@@ -106,6 +107,10 @@ private function getConfig(): array
             [
                 'key' => "$configKey.h5p_save_content_frequency",
                 'value' => $h5p_save_content_frequency,
+            ],
+            [
+                'key' => "$configKey.url",
+                'value' => $h5p_url,
             ]
         ];
     }
@@ -215,6 +220,16 @@ private function getAssertData(): array
                 'readonly' => false,
                 'value' => 3,
             ],
+            'url' => [
+                'full_key' => "$configKey.url",
+                'key' => 'url',
+                'rules' => [
+                    'string'
+                ],
+                'public' => false,
+                'readonly' => false,
+                'value' => 'h5p-test',
+            ],
         ];
     }
 }