Java 8 support - Kryo 4.0.0 - JsonBeans 0.7 - Listener, Client and Server discovers refactored into an interface #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Java 8 support - Kryo 4.0.0 - JsonBeans 0.7 - Listener, Client and Server discovers refactored into an interface -
Smells like you accidentally changed the line-endings. |
|
@CookedApps I did not tested, but I don't think so, sorry |
|
@CookedApps I just cherry picked my commit onto this and sent @Pyeroh a pull request. In the meantime, I'm using |
Fix UDP recieving on Android 5.0+
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It solves #77 and #39, by updating to Java 8 and using defender methods. It also removes unnecessary libs : you uses maven, and defines dependencies. Why maintaining dependencies in multiple places ?
I don't get why the diff marks there are differences between source files, as I didn't change tabs/spaces...
BTW, I think pushing an updated version of this lib on maven repositories would be great, as the only available version is a RC.
Thanks for reviewing !