Skip to content

Commit

Permalink
a little cleanup on comment
Browse files Browse the repository at this point in the history
  • Loading branch information
dailinsubjam committed Dec 19, 2023
1 parent da7d7e9 commit 95bce93
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
1 change: 0 additions & 1 deletion crates/testing/src/task_helpers.rs
Original file line number Diff line number Diff line change
Expand Up @@ -279,7 +279,6 @@ async fn build_quorum_proposal_and_signature(
timeout_certificate: None,
proposer_id: leaf_view2.proposer_id,
};
error!("Have you really entered view 2?");
return (proposal_view2, signature_view2);
}

Expand Down
4 changes: 2 additions & 2 deletions crates/testing/tests/consensus_task.rs
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,7 @@ async fn test_consensus_with_vid() {
// For the test of vote logic with vid, starting view 2 we need vid share
input.push(HotShotEvent::ViewChange(ViewNumber::new(2)));
let proposal_view2 = build_quorum_proposal(&handle, &private_key_view2, 2).await;
// Sishan TODO: Still need a valid DAC cert
// TODO: Still need a valid DAC cert, now tracking logging instead
// https://github.com/EspressoSystems/HotShot/issues/2255
input.push(HotShotEvent::VidDisperseRecv(vid_proposal.clone(), pub_key));

Expand All @@ -213,7 +213,7 @@ async fn test_consensus_with_vid() {
);
output.insert(HotShotEvent::VidDisperseRecv(vid_proposal, pub_key), 1);

// Sishan TODO: Uncomment this after the above TODO is done
// TODO: Uncomment this after the above TODO is done
// https://github.com/EspressoSystems/HotShot/issues/2255
// if let GeneralConsensusMessage::Vote(vote) = build_vote(&handle, proposal_view2.data).await {
// output.insert(HotShotEvent::QuorumVoteSend(vote.clone()), 1);
Expand Down

0 comments on commit 95bce93

Please sign in to comment.