Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Test Stricter #1917

Merged
merged 1 commit into from
Oct 16, 2023
Merged

Make Test Stricter #1917

merged 1 commit into from
Oct 16, 2023

Conversation

bfish713
Copy link
Collaborator

  • Increase the expected view success for the failure tests. At 10 they were not really testing what happened after a bad node
  • Increase duration of failure tests to allow for timeouts and view sync to happen
  • Decrease default failures and expect the correct number of failures based on specific tests.
  • Tighten up the default timings. Makes propose time much shorter which allows for timeout to be decreased significantly. Rounds should complete faster in general now, and the for tests wit expected timeouts they should run 5 times as fast.
  • Add more delay at startup. I noticed the first leader was proposing before we spun up all nodes triggering weird behavior which isn't realistic (or what the tests want to test). This fixes that.

shenkeyao
shenkeyao approved these changes Oct 13, 2023
View reviewed changes
Copy link
Member

@shenkeyao shenkeyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bfish713 bfish713 merged commit 4da489b into main Oct 16, 2023
6 checks passed
@bfish713 bfish713 deleted the bf/stricter-tests branch October 16, 2023 22:12
@dailinsubjam dailinsubjam mentioned this pull request Nov 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elliedavidson elliedavidson elliedavidson approved these changes

@shenkeyao shenkeyao shenkeyao approved these changes

@DieracDelta DieracDelta Awaiting requested review from DieracDelta

@rob-maron rob-maron Awaiting requested review from rob-maron

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bfish713 @shenkeyao @elliedavidson