[Stability] Cancel polling for old votes #2223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bfish713
requested changes
Dec 13, 2023
bfish713
reviewed
Dec 13, 2023
crates/task-impls/src/view_sync.rs
Outdated
| @@ -465,6 +465,13 @@ impl< | |||
| return; | |||
| } | |||
|
|
|||
| // cancel poll for votes | |||
| self.network | |||
| .inject_consensus_info(ConsensusIntentEvent::CancelPollForViewSyncVotes( | |||
There was a problem hiding this comment.
I think it was correct before, we just timed out consensus for the round and are now maybe entering view sync, we should cancel polling for quorum votes and proposals but that should be handled in the consensus task
bfish713
reviewed
Dec 13, 2023
| @@ -975,6 +993,11 @@ impl<TYPES: NodeType, I: NodeImplementation<TYPES>, A: ConsensusApi<TYPES, I> + | |||
| return; | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Cancel poll for proposal here too, I think
bfish713
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2222
This PR:
Fixes a bug wherein we are not cancelling old polls for votes.
Cancels polls for votes in the following places:
Also cancels a poll for proposals for view 1, as this is covered by the latest proposal mechanism. For a node finishing catchup, it would constantly try to pull the first proposal.
This PR does not:
Add any GC improvements/more advanced proposal logic/cancelling as discussed. This will be in another PR.
Key places to review:
da.rs,consensus.rs,view_sync.rsto make sure all the cancels are in a good spot.