-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new leaf type #3761
Open
ss-es
wants to merge
24
commits into
main
Choose a base branch
from
ss/leaf2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add new leaf type #3761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
Leaf2
,QuorumProposal2
,QuorumVote2
,QuorumCertificate2
andQuorumData2
types. Note: these types are purely internal at this time.Leaf
,QuorumProposal
etc) types and the newly added typesmigrate_consensus
function that is invoked onSystemContext::init
, which converts fromLeaf
toLeaf2
in storage.This PR does not:
QuorumProposal2
out, instead of downgrading toQuorumProposal
in the network task) on a version upgrade has not yet been implemented -- this will be done once all types are finalized.Leaf2
andQuorumProposal2
structs are not final and should not be deployed.Key places to review:
The
types/**
crate is the source of the changes and should be reviewed most closely.