Add proof validation to batch poster #301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds calls to the espresso validation code to the batch poster to validate the namespace proof and merkle proof in a TEE
zacshowa
requested review from
ImJeremyHe,
alysiahuggins,
Sneh1999,
sveitser and
jbearer
as code owners
ImJeremyHe
approved these changes
Nov 12, 2024
…so-integration into add-validation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #291
This PR:
Adds calls to the espresso validation code to the batch poster to validate the namespace proof and merkle proof in a TEE.
This PR also adds sets the switch delay threshold field in the builder configs for the tests in
system_tests/espresso_sovereign_sequencer_test.goas previously it was not set.This PR does not:
Add any new tests for this logic, it should already be covered by the tests of the validation code itself.
Key places to review:
Additions in
arbnode/batch_poster.goAddition in
system_tests/espresso_sovereign_sequencer_test.goHow to test this PR:
Run the E2E test with
go test -run ^TestEspressoE2E github.com/offchainlabs/nitro/system_tests -vThings tested
Building the docker image locally, passing the E2E test locally