Not trimmer friendly in .NET 8

[espenrl]

Hi, I'm experiencing some issues with trimming on iOS and Android using toolkit 200.3.0.

ILLink : error IL2036: Esri.ArcGISRuntime.Toolkit.Maui.Primitives.AttachmentsPopupElementView.BuildDefaultItemTemplate(): Unresolved type 'Esri.ArcGISRuntime.Toolkit.Maui.Primitives.AttachmentViewModel' in 'DynamicDependencyAttribute'.
ILLink : error IL2037: Esri.ArcGISRuntime.Toolkit.Maui.OverviewMap..cctor(): No members were resolved for 'LoadStatus' on type 'Esri.ArcGISRuntime.Mapping.Map'. 

Temporary fix

<PropertyGroup>
    <NoWarn>$(NoWarn);IL2036;IL2037</NoWarn>
</PropertyGroup>

Investigation

arcgis-maps-sdk-dotnet-toolkit/src/Toolkit/Toolkit/UI/Controls/PopupViewer/AttachmentsPopupElementView.Maui.cs

Lines 76 to 80 in 8117823

	[DynamicDependency(nameof(AttachmentViewModel.Thumbnail), "Esri.ArcGISRuntime.Toolkit.Maui.Primitives.AttachmentViewModel","Esri.ArcGISRuntime")]
	[DynamicDependency(nameof(AttachmentViewModel.Name), "Esri.ArcGISRuntime.Toolkit.Maui.Primitives.AttachmentViewModel", "Esri.ArcGISRuntime")]
	[DynamicDependency(nameof(AttachmentViewModel.Size), "Esri.ArcGISRuntime.Toolkit.Maui.Primitives.AttachmentViewModel", "Esri.ArcGISRuntime")]
	[DynamicDependency(nameof(AttachmentViewModel.IsDownloadButtonVisible), "Esri.ArcGISRuntime.Toolkit.Maui.Primitives.AttachmentViewModel", "Esri.ArcGISRuntime")]
	[DynamicDependency(nameof(AttachmentViewModel.IsDownloading), "Esri.ArcGISRuntime.Toolkit.Maui.Primitives.AttachmentViewModel", "Esri.ArcGISRuntime")]

AttachmentViewModel is a private class nested inside AttachmentsPopupElementView. I guess the full type name is incorrect.

arcgis-maps-sdk-dotnet-toolkit/src/Toolkit/Toolkit/UI/Controls/PopupViewer/AttachmentsPopupElementView.Maui.cs

Lines 189 to 194 in 8117823

	private class AttachmentViewModel : System.ComponentModel.INotifyPropertyChanged
	{
	public AttachmentViewModel(PopupAttachment attachment)
	{
	Attachment = attachment;
	Attachment.PropertyChanged += Attachment_PropertyChanged;

I haven't investigated the second error..

[dotMorten]

Good find! You're right the full type name is incorrect for AttachmentViewModel.
The other one I think it just need to change from Map.LoadStatus to GeoModel.LoadStatus

arcgis-maps-sdk-dotnet-toolkit/src/Toolkit/Toolkit.Maui/OverviewMap/OverviewMap.cs

Line 36 in 8117823

[DynamicDependency(nameof(Esri.ArcGISRuntime.Mapping.Map.LoadStatus), "Esri.ArcGISRuntime.Mapping.Map", "Esri.ArcGISRuntime")]

Having said that, trimming in .NET MAUI is still pretty limited and causing a lot of issues beyond the .NET SDKs's own libraries - even .NET MAUI has lots of issues and are still working through it. Generally I'd recommend turning trimming off for Esri.ArcGISRuntime since especially bindings are causing a lot of issues since MAUI can't properly analyze and preserve properties you're binding to. If you want to keep trimming on for our libraries, expect doing a lot of these DynamicDependency attributes for things you bind to but don't access directly in code-behind, and as this issue shows, it can be pretty error-prone.