Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BugFix: Not trimmer friendly in .NET 8 #551

Merged
merged 2 commits into from
Feb 21, 2024
Merged

BugFix: Not trimmer friendly in .NET 8 #551

merged 2 commits into from
Feb 21, 2024

Conversation

prathameshnarkhede
Copy link
Contributor

BugFix: Not trimmer friendly in .NET 8 (Related Issue #538)

  • Fixed namespace for AttachmentViewModel.
  • Fixed namespace and ClassName for LoadStatus property to reference from GeoModel instead of Map.
  • Added warnings IL2036 and IL2037 to treat them as errors.

@prathameshnarkhede
# BugFix:
ebc78fd 
Not trimmer friendly in .NET 8
   - Fixed namespace for `AttachmentViewModel`.
   - Fixed namespace and ClassName for `LoadStatus` property to refernce from `GeoModel` instead of `Map`.
   - Added warnings `IL2036` and `IL2037` to treat them as errors.
@prathameshnarkhede prathameshnarkhede linked an issue Feb 20, 2024 that may be closed by this pull request
Not trimmer friendly in .NET 8 #538
Closed
@prathameshnarkhede prathameshnarkhede self-assigned this Feb 20, 2024
dotMorten
dotMorten approved these changes Feb 20, 2024
View reviewed changes
Copy link
Member

@dotMorten dotMorten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - just a minor indenting issue

src/Samples/Toolkit.SampleApp.Maui/Toolkit.SampleApp.Maui.csproj Outdated Show resolved Hide resolved
@prathameshnarkhede prathameshnarkhede merged commit 9276b00 into main Feb 21, 2024
1 check passed
@prathameshnarkhede prathameshnarkhede deleted the pratham/538-not-trimmer-friendly-in-net-8 branch February 21, 2024 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mstefarov mstefarov mstefarov approved these changes

@dotMorten dotMorten dotMorten approved these changes

Assignees

@prathameshnarkhede prathameshnarkhede

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Not trimmer friendly in .NET 8
3 participants
@prathameshnarkhede @mstefarov @dotMorten