PopupViewer bugfix roundup #516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix accidentally-inverted condition that caused all align values to be ignored. - Add "p" to list of tags that can have align attribute.
dotMorten
approved these changes
Jun 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Three improvements for WPF PopupViewer's text element support:
Parse font sizes expressed in points (pt)
Ran into this in a few Living Atlas layers, e.g. National Weather Service Wind Speed Forecast:
Don't let image load errors take down the app
When a RuntimeImage representing an
<img>fails to load (e.g. broken link or unsupported format), an unhandled exception is currently thrown. I think it's better to suppress it -- users already see a LoadError printed to console. A broken image link in a popup should not be catastrophic.Fix handling of "align" HTML attribute
An accidentally-inverted condition caused all valid align values to be ignored. Also,
<p>was missing from the list of tags that can have align attribute.