wpf: PopupViewer bugfixes wave 2 #518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mstefarov
force-pushed
the
matvei/popup-viewer-fixes-2
branch
from
bd77859
to
bd3f310
Compare
dotMorten
approved these changes
Jul 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found and fixed a few bugs in WPF PopupViewer during the past 3 months, but didn't get a chance to do a write-up and submit them yet. Here is batch 2 of 3.
Font size fixes
FlowDocument's default font size is smaller than intended (12 instead of 14). This means we defaulted to "small" instead of "medium", which threw all relative sizing off. Also, an extra space prevented "large" font size from parsing properly. Example from the Living Atlas:
Before
After
Reference (AGOL)
Implement colspan and rowspan for tables
WPF tables already support rowspan/colspan, so this was a trivial TODO to implement. Example from the Living Atlas
Before
After
Reference (AGOL)
Apply alignment to TableCells and ListItems
Turns out TableCells and ListItems do not extend Block in WPF, but instead have their own copies of the TextAlignment property. This resulted in badly-aligned tables on a few maps, e.g. the on the infamous "road signs" one. This thing is like an Acid test for popup rendering. We can't match reference rendering yet, but we're getting closer! 🙂
Apply style to links
There was a missing call to ApplyStyle when rendering links in WPF. This means links always had default styling and didn't pick up e.g. color / bold / italic attributes.