Added doc for GeoViewController #535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotMorten
reviewed
Dec 6, 2023
docs/geoviewcontroller.md
Outdated
| GeoViewController is a helper class for enabling MVVM patterns adoption is an ArcGIS Maps SDK for .NET applications. | ||
| The helper class allows you to perform view operations on the MapView from your ViewModel, through an attached proxy-object that ensures you keep ViewModel and View separated. | ||
|
|
||
|  |
docs/geoviewcontroller.md
Outdated
|
|
||
| - GeoViewController class can manage most common `GeoView` operations like setting viewpoint, performing identify and showing callouts. Any specific `MapView` or `SceneView` operations are not accessible via this helper class. | ||
| - The helpher class is extensible so you can add your own custom map and scene operations, or interface for allowing testing (see WPF sample). | ||
| - Currently, there are no events exposed. You can use `EventToCommand` or any similar already established approach to forward view events back to the ViewModel (see samples). |
There was a problem hiding this comment.
Remove. It makes it sound like this might come. The controller was never needed to do this in the first place
dotMorten
reviewed
Dec 6, 2023
| <esri:MapView x:Name="MyMapView" | ||
| Map="{Binding Map, Source={StaticResource VM}}" | ||
| toolkit:GeoViewController.GeoViewController="{Binding Controller, Source={StaticResource VM}}"> | ||
| ``` |
There was a problem hiding this comment.
Should the VM code be included?
There was a problem hiding this comment.
I was thinking about it but then I thought it would be like pasting the entire sample code. I think users can refer to WPF sample, if needed.
dotMorten
approved these changes
Dec 6, 2023
ThadT
approved these changes
Dec 6, 2023
| @@ -24,6 +24,7 @@ The ArcGIS Maps SDK for .NET Toolkit contains controls and components to acceler | |||
| | [Compass](docs/compass.md) |  | Show a compass direction when the map or scene is rotated. | WinUI, MAUI, UWP, WPF | | |||
| | [FeatureDataField](docs/feature-data-field.md) |  | Display and optionally allow editing of a single field attribute of a feature. | UWP, WPF | | |||
| |[FloorFilter](docs/floor-filter.md) |  | Browse floor-aware maps and scenes and filter the view to show levels in a facility. | WinUI, MAUI, UWP, WPF | | |||
| |[GeoViewController](docs/geoviewcontroller.md) | | A helpfer class to enable easy adoption of MVVM patterns in an ArcGIS Maps SDK for .NET application. | WinUI, MAUI, UWP, WPF | | |||
There was a problem hiding this comment.
Suggested change
| |[GeoViewController](docs/geoviewcontroller.md) | | A helpfer class to enable easy adoption of MVVM patterns in an ArcGIS Maps SDK for .NET application. | WinUI, MAUI, UWP, WPF | | |
| |[GeoViewController](docs/geoviewcontroller.md) | | A helper class to enable easy adoption of MVVM patterns in an ArcGIS Maps SDK for .NET application. | WinUI, MAUI, UWP, WPF | |
| @@ -32,6 +32,10 @@ Browse floor-aware maps and scenes and filter the view to show levels in a facil | |||
|
|
|||
|  | |||
|
|
|||
| ### GeoViewController | |||
|
|
|||
| A helper class for enabling easy adoption of MVVM patterns in ArcGIS Maps SDK for .NET applications. | |||
There was a problem hiding this comment.
I think most people will know what MVVM means, but just to be safe (?).
Suggested change
| A helper class for enabling easy adoption of MVVM patterns in ArcGIS Maps SDK for .NET applications. | |
| A helper class for enabling easy adoption of [Model-View-ViewModel (MVVM)](https://learn.microsoft.com/en-us/dotnet/architecture/maui/mvvm) patterns in ArcGIS Maps SDK for .NET applications. |
| @@ -0,0 +1,25 @@ | |||
| # GeoViewController | |||
|
|
|||
| GeoViewController is a helper class for enabling easy adoption of MVVM patterns in ArcGIS Maps SDK for .NET applications. | |||
There was a problem hiding this comment.
Suggested change
| GeoViewController is a helper class for enabling easy adoption of MVVM patterns in ArcGIS Maps SDK for .NET applications. | |
| GeoViewController is a helper class for enabling easy adoption of [Model-View-ViewModel (MVVM)](https://learn.microsoft.com/en-us/dotnet/architecture/maui/mvvm) patterns in ArcGIS Maps SDK for .NET applications. |
Comment on lines
+10
to
+11
| - GeoViewController class can manage most common `GeoView` operations like setting viewpoint, performing identify and showing callouts. Any specific `MapView` or `SceneView` operations are not accessible via this helper class. | ||
| - The helper class is extensible. You can add your own custom map and scene operations, or interface for enabling testing (see WPF sample). |
There was a problem hiding this comment.
Suggested change
| - GeoViewController class can manage most common `GeoView` operations like setting viewpoint, performing identify and showing callouts. Any specific `MapView` or `SceneView` operations are not accessible via this helper class. | |
| - The helper class is extensible. You can add your own custom map and scene operations, or interface for enabling testing (see WPF sample). | |
| - GeoViewController class can manage most common `GeoView` operations like setting a viewpoint, performing identify, and showing callouts. Any specific `MapView` or `SceneView` operations are not accessible via this helper class. | |
| - The helper class is extensible. You can add your own custom map and scene operations or an interface to enable testing (see WPF sample). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add markdown for GeoViewController