MeasureToolbar: modify ArgumentException message
#539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any idea why the job might fail if the solution is building for me locally? |
|
All resolved - updated the certificate for UWP, changes included in this PR. |
dotMorten
requested changes
Jan 4, 2024
Comment on lines
600
to
596
| DependencyProperty.Register(nameof(LineSketchEditor), typeof(SketchEditor), typeof(MeasureToolbar), new PropertyMetadata(null, OnLineSketchEditorPropertyChanged)); | ||
| DependencyProperty.Register(nameof(LineSketchEditor), typeof(SketchEditor), typeof(MeasureToolbar), new PropertyMetadata(null, OnSketchEditorPropertyChanged)); | ||
|
|
||
| private static void OnLineSketchEditorPropertyChanged(DependencyObject d, DependencyPropertyChangedEventArgs e) | ||
| private static void OnSketchEditorPropertyChanged(DependencyObject d, DependencyPropertyChangedEventArgs e) |
There was a problem hiding this comment.
Why this change? It's literally the 'LineSketchEditor' property. Please undo
| @@ -631,26 +625,7 @@ private static void OnLineSketchEditorPropertyChanged(DependencyObject d, Depend | |||
| /// Identifies the <see cref="AreaSketchEditor"/> dependency property. | |||
| /// </summary> | |||
| public static readonly DependencyProperty AreaSketchEditorProperty = | |||
| DependencyProperty.Register(nameof(AreaSketchEditor), typeof(SketchEditor), typeof(MeasureToolbar), new PropertyMetadata(null, OnLineSketchEditorPropertyChanged)); | |||
There was a problem hiding this comment.
This is the only bug. It should call OnAreaSketchEditorPropertyChanged instead, and don't delete the code below.
This reverts commit ea7aae9.
dotMorten
approved these changes
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When registering the
DependencyPropertys forLineSketchEditorandAreaSketchEditor, they are both using the same method for thePropertyMetadataPropertyChangedCallbackparameter. This is fine, but currently the exception message when the new value is null doesn't make sense forAreaSketchEditor. To remedy this, I would like to remove the unused method and modify the currently used method to make sense in both cases.Also, I removed some redundant "using" statements and corrected a typo.