J nery/build warnings #572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mstefarov
approved these changes
May 20, 2024
Comment on lines
+22
to
+24
| #pragma warning disable CA1001 | ||
| public partial class UtilityNetworkTraceTool | ||
| #pragma warning restore CA1001 |
There was a problem hiding this comment.
Normally I'd ask for UNTraceTool to be made disposble instead of suppressing warnings. However, looks like the only cancelable things in the UNTraceToolController are CancellationTokenSources, which aren't as big to leave un-disposed (e.g. see dotnet/runtime#29970 (comment)). So I am okay with this.
dotMorten
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To handle the following warnings
.NET MAUI and WinUI do not like disposable objects being part of a class that is not disposable.
UtilityNetworkTraceToolcould dispose these objects when unloaded, but followed the same pattern that was done onSearchViewUtilityNetworkChangedwas not raised on .NET Maui and while fixing this, foundUtilityNetworkTraceCompletedcould be raised twice.