PopupViewer WinUI/UWP #589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adds support for the barcode input field
* Added support to override URL clicks in PopupViewer * Added samples for reference * Refactor PopupViewer and event handling * Refactor hyperlink event handling and cleanup - Corrected the event name from `HyperLinkClicked` to `HyperlinkClicked` in both XAML and code-behind files for consistency and to meet case sensitivity requirements. * Refactor GetPopupViewerParent to generic * Refactor GetParent<T> generic constraint * Broaden type check in Tapped event handler * Refine type checks and adjust imports * Refactor PopupViewer parent traversal logic
…t by re-evaluating expressions All add Finish method for consistency
Ensures on catalyst that the textfield isn't blocked form clicking when there's an error
* Optimize BasemapGallery initialization Removed redundant initialization of `AvailableBasemaps` in the `BasemapGallery` constructor. Added a null check in `BasemapGallery_Loaded` to initialize `AvailableBasemaps` only if it is null, calling `_controller.LoadFromDefaultPortal()` asynchronously if needed. This change prevents unnecessary initialization and allows for external setting of `AvailableBasemaps` before the control is loaded. * Initialize AvailableBasemaps and improve load check Add initialization flag for BasemapGallery collection
# Conflicts: # src/Toolkit/Toolkit/UI/Controls/FeatureForm/AttachmentsFormElementView.Windows.cs # src/Toolkit/Toolkit/UI/Controls/PopupViewer/FieldsPopupElementView.cs # src/Toolkit/Toolkit/UI/Controls/PopupViewer/PopupViewer.Windows.cs # src/Toolkit/Toolkit/UI/Controls/PopupViewer/PopupViewer.cs
mstefarov
reviewed
Aug 2, 2024
src/Toolkit/Toolkit.WinUI/UI/Controls/PopupViewer/PopupViewer.Theme.xaml
Outdated
Show resolved
Hide resolved
src/Toolkit/Toolkit.WinUI/UI/Controls/PopupViewer/PopupViewer.Theme.xaml
Outdated
Show resolved
Hide resolved
mstefarov
approved these changes
Aug 5, 2024
prathameshnarkhede
approved these changes
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brings the new PopupElement-based implementation to UWP and WinUI3 and brings equivalence to WPF and .NET MAUI.
This also fixes #496 by upgrading WinUI