Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Update] Improve Sample Viewer search #228

Merged
merged 34 commits into from
Aug 15, 2023
Merged

[Update] Improve Sample Viewer search #228

merged 34 commits into from
Aug 15, 2023

Commits on Jul 19, 2023

  1. Update sample search functionality.

    @CalebRas
    CalebRas committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    fa7d112 View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2023

  1. Update comments.

    @CalebRas
    CalebRas committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    acf201a View commit details
    Browse the repository at this point in the history

  2. Add bolded query text.

    @CalebRas
    CalebRas committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    f0f6598 View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2023

  1. Update search text.

    @CalebRas
    CalebRas committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    76dce08 View commit details
    Browse the repository at this point in the history

Commits on Jul 28, 2023

  1. Update search section names.

    @CalebRas
    CalebRas committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    4cd0684 View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2023

  1. Update section headers.

    @CalebRas
    CalebRas committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    ee03f36 View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2023

  1. Apply suggestions from code review. 

    Co-authored-by: Ting <tchen@esri.com>
    @CalebRas @yo1995
    CalebRas and yo1995 authored Aug 2, 2023
    Configuration menu
    Copy the full SHA
    ad833a9 View commit details
    Browse the repository at this point in the history

  2. Add temporary results.

    @CalebRas
    CalebRas committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    71bcbff View commit details
    Browse the repository at this point in the history

  3. Apply suggestions from code review. 

    Co-authored-by: Ting <tchen@esri.com>
    @CalebRas @yo1995
    CalebRas and yo1995 authored Aug 2, 2023
    Configuration menu
    Copy the full SHA
    786ed77 View commit details
    Browse the repository at this point in the history

  4. Update search methods. 

    #228 (comment)
    @CalebRas
    CalebRas committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    f292a59 View commit details
    Browse the repository at this point in the history

Commits on Aug 3, 2023

  1. Remove returns from methods. 

    #228 (comment)
    @CalebRas
    CalebRas committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    c0802f6 View commit details
    Browse the repository at this point in the history

  2. Add newValue to onChange. 

    #228 (comment)
    @CalebRas
    CalebRas committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    f187a74 View commit details
    Browse the repository at this point in the history

  3. Update bold text. 

    #228 (comment)
    @CalebRas
    CalebRas committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    cc3de81 View commit details
    Browse the repository at this point in the history

Commits on Aug 4, 2023

  1. Add string extension. 

    #228 (comment)
    @CalebRas
    CalebRas committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    fc79817 View commit details
    Browse the repository at this point in the history

  2. Update code generation.

    @CalebRas
    CalebRas committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    47626b4 View commit details
    Browse the repository at this point in the history

  3. Update set operations. 

    #235 (comment)
    @CalebRas
    CalebRas committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    4e849ee View commit details
    Browse the repository at this point in the history

  4. Merge pull request #235 from Esri/Caleb/Fix-RemoveRelevantAPIsFromTags 

    [Fix] Remove the relevant APIs from the tags in the `Sample` struct
    @CalebRas
    CalebRas authored Aug 4, 2023
    Configuration menu
    Copy the full SHA
    2c05af4 View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2023

  1. Apply suggestions from code review. 

    Co-authored-by: Philip Ridgeway <pridgeway@esri.com>
    @yo1995 @philium
    yo1995 and philium authored Aug 7, 2023
    Configuration menu
    Copy the full SHA
    ba8edfa View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2023

  1. Address feedback from code review.

    @yo1995
    yo1995 committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    569ce4e View commit details
    Browse the repository at this point in the history

  2. Adjust newlines.

    @yo1995
    yo1995 committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    2b6c5d3 View commit details
    Browse the repository at this point in the history

  3. Add files to project file.

    @yo1995
    yo1995 committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    528a95d View commit details
    Browse the repository at this point in the history

  4. Update content display logics.

    @yo1995
    yo1995 committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    fee4d34 View commit details
    Browse the repository at this point in the history

  5. Update comments in code generation script.

    @yo1995
    yo1995 committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    a98173f View commit details
    Browse the repository at this point in the history

  6. Fix the script.

    @yo1995
    yo1995 committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    4792c37 View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2023

  1. Apply suggestions from code review. 

    Co-authored-by: Philip Ridgeway <pridgeway@esri.com>
    @yo1995 @philium
    yo1995 and philium authored Aug 9, 2023
    Configuration menu
    Copy the full SHA
    17ac880 View commit details
    Browse the repository at this point in the history

  2. Update Shared/Supporting Files/Views/SampleRow.swift 

    Use `symbolVariant` instead of ternary operator.

Co-authored-by: Philip Ridgeway <pridgeway@esri.com>
    @yo1995 @philium
    yo1995 and philium authored Aug 9, 2023
    Configuration menu
    Copy the full SHA
    ab11d91 View commit details
    Browse the repository at this point in the history

  3. Update Scripts/GenerateSampleViewSourceCode.swift. 

    Only make the tags a set at the last step of code generation, so it keeps the order for the most part.

Co-authored-by: Philip Ridgeway <pridgeway@esri.com>
    @yo1995 @philium
    yo1995 and philium authored Aug 9, 2023
    Configuration menu
    Copy the full SHA
    d7e652f View commit details
    Browse the repository at this point in the history

  4. Rename views and add Sidebar. 

    See: #228 (comment)
    @yo1995
    yo1995 committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    b96f96b View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2023

  1. Address feedback from code review.

    @yo1995
    yo1995 committed Aug 10, 2023
    1 Configuration menu
    Copy the full SHA
    9e3106c View commit details
    Browse the repository at this point in the history

  2. Use sidebar as before.

    @yo1995
    yo1995 committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    16224c0 View commit details
    Browse the repository at this point in the history

  3. Remove unneeded property.

    @yo1995
    yo1995 committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    9311c82 View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2023

  1. Reorder properties in ContentView.

    @yo1995
    yo1995 committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    0dc8ff2 View commit details
    Browse the repository at this point in the history

  2. Make properties non-private. 

    To allow the compiler to synthesize the default initializer.
    @yo1995
    yo1995 committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    3f8c221 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'v.next' into Caleb/Update-SampleViewerSearchBar

    @yo1995
    yo1995 committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    62e0b96 View commit details
    Browse the repository at this point in the history