-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[New] Display alternate symbols at different scales #522
Merged
CalebRas
merged 8 commits into
v.next
from
Caleb/New-DisplayAlternateSymbolsAtDifferentScales
Oct 17, 2024
Merged
[New] Display alternate symbols at different scales #522
CalebRas
merged 8 commits into
v.next
from
Caleb/New-DisplayAlternateSymbolsAtDifferentScales
Oct 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CalebRas
requested review from
a team,
pgruenler and
njarecha
and removed request for
a team
October 16, 2024 16:32
pgruenler
requested changes
Oct 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One documentation comment looks incomplete.
...lay alternate symbols at different scales/DisplayAlternateSymbolsAtDifferentScalesView.swift
Outdated
Show resolved
Hide resolved
pgruenler
previously approved these changes
Oct 16, 2024
njarecha
previously approved these changes
Oct 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Sorry I had to merged with v.next. |
njarecha
approved these changes
Oct 17, 2024
pgruenler
approved these changes
Oct 17, 2024
Thank you! |
CalebRas
deleted the
Caleb/New-DisplayAlternateSymbolsAtDifferentScales
branch
October 17, 2024 17:19
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements
Display alternate symbols at different scales
inSAMPLE_CATEGORY
category.URL to README: Display alternate symbols at different scales
Linked Issue(s)
swift/issues/6187
How To Test
Screenshots