Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update table to pdf #2133

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Update table to pdf #2133

wants to merge 5 commits into from

Conversation

nanaeaubry
Copy link
Contributor

This probably needs to be run to double check it's as expected

jyaistMap and others added 4 commits September 26, 2024 13:14
Aligning next with master for relative links
aligning branches so next is only ahead of master
@nanaeaubry nanaeaubry added the documentation Bugs and enhancement requests for doc (API ref and notebooks) label Oct 23, 2024
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@@ -1246,8 +1246,7 @@
],
Copy link
Contributor

@cariashuang0417 cariashuang0417 Oct 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reference 3 needs to be updated to the new doc :)


Reply via ReviewNB

Copy link
Contributor

@cariashuang0417 cariashuang0417 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me (just a reference for print method need to update)! 😃

Note: Looks like the table data (https://www.fire.ca.gov/our-impact/statistics/) and usa counties are out-of-date. May need future re-visit on this sample some day.

@nanaeaubry nanaeaubry changed the base branch from next to master October 24, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Bugs and enhancement requests for doc (API ref and notebooks)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants