Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update features edit sample #2137

Merged
merged 4 commits into from
Nov 27, 2024
Merged

Update features edit sample #2137

merged 4 commits into from
Nov 27, 2024

Conversation

nanaeaubry
Copy link
Contributor

Use Folder add instead of ContentManager add

@nanaeaubry nanaeaubry added the documentation Bugs and enhancement requests for doc (API ref and notebooks) label Oct 23, 2024
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Contributor

@cariashuang0417 cariashuang0417 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A little tweak is needed. Everything else looks good to me!

Copy link
Collaborator

@jyaistMap jyaistMap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nanaeaubry - Can you please address the conflicts?

@nanaeaubry nanaeaubry requested a review from jyaistMap November 11, 2024 07:29
@nanaeaubry
Copy link
Contributor Author

@jyaistMap Resolved conflicts

Copy link
Collaborator

@jyaistMap jyaistMap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks @nanaeaubry

@jyaistMap jyaistMap merged commit 92685ef into master Nov 27, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Bugs and enhancement requests for doc (API ref and notebooks)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants