fix(modal): fix issue caused by early opening logic calls #11498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
bug
jcfranco
added
the
pr ready for visual snapshots
jcfranco
added
the
no changelog entry
jcfranco
deleted the
jcfranco/10731-fix-error-caused-by-missing-transitionEl-when-opening
branch
benelan
pushed a commit
that referenced
this pull request
Feb 8, 2025
Merged
geospatialem
modified the milestones:
2025-02-25 - Feb Milestone,
2025-02-06 - 3.0.0 Feb Breaking Change Release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #10731
Summary
Fixes an issue where the modal’s opening logic was invoked before the transition element was available. This adds a simple guard for now, but I’ll revisit later to ensure the method isn’t called until after the component updates.
BEGIN_COMMIT_OVERRIDE
omitted from changelog
END_COMMIT_OVERRIDE