Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: increase release-please commit search depth #11501

Merged
merged 1 commit into from
Feb 8, 2025

Conversation

benelan
Copy link
Member

@benelan benelan commented Feb 8, 2025

Summary

By default, release-please only checks 500 commits when searching for the previous release. That number can be increased with the commit-search-depth manifest option. Changing the value to 1000 will be more than enough according to my calculation:

git rev-list @esri/calcite-components@2.13.2...origin/main | wc -l # => 793

@benelan benelan requested a review from jcfranco as a code owner February 8, 2025 02:58
@github-actions github-actions bot added the chore Issues with changes that don't modify src or test files. label Feb 8, 2025
@benelan benelan added the skip visual snapshots Pull requests that do not need visual regression testing. label Feb 8, 2025
@benelan
Copy link
Member Author

benelan commented Feb 8, 2025

pushing this through to continue with the release, cc @jcfranco

@benelan benelan merged commit 5138f7d into dev Feb 8, 2025
16 checks passed
@benelan benelan deleted the benelan/release-please-search-depth branch February 8, 2025 03:02
@github-actions github-actions bot added this to the 2025-02-25 - Feb Milestone milestone Feb 8, 2025
benelan added a commit that referenced this pull request Feb 8, 2025
## Summary

By default, release-please only checks 500 commits when searching for
the previous release. That number can be increased with the
`commit-search-depth` [manifest] option. Changing the value to 1000 will
be more than enough according to my calculation:

```sh
git rev-list @esri/calcite-components@2.13.2...origin/main | wc -l # => 793
```

[manifest]: https://github.com/googleapis/release-please/blob/90058f543cd82858539fdc7d1b34eabd348edbee/docs/manifest-releaser.md?plain=1#L243-L249
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Issues with changes that don't modify src or test files. skip visual snapshots Pull requests that do not need visual regression testing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants