Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename to ArcGIS CityEngine for Unreal Engine #159

Merged
merged 8 commits into from
Dec 16, 2024
Merged

Conversation

bneukom
Copy link
Collaborator

@bneukom bneukom commented Dec 12, 2024

We still keep all the internal names Vitruvio as this would cause to much overhead and possibly break backwards compatibility.

@bneukom bneukom changed the title Rename public visible plugin name to ArcGIS CityEngine Plugin (for Unreal) Rename to ArcGIS CityEngine Plugin (for Unreal) Dec 12, 2024
@bneukom bneukom requested a review from arisona December 12, 2024 15:39
Copy link
Collaborator

@arisona arisona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mistafunk
Copy link
Collaborator

You sometimes call it "CityEngine Plugin for Unreal" and sometimes "(ArcGIS) CityEngine for Unreal"... Consider using the latter for consistency with rhino and the product guidelines ("plugin" is never used for integrations).

@bneukom
Copy link
Collaborator Author

bneukom commented Dec 13, 2024

Thanks @mistafunk ! There are still some mentions of "plugin" but only when it makes sense (because of the Unreal usecase). Removed it in all "official" names.

@bneukom bneukom changed the title Rename to ArcGIS CityEngine Plugin (for Unreal) Rename to ArcGIS CityEngine for Unreal Engine Dec 13, 2024
@bneukom bneukom force-pushed the bneukom/plugin_rename branch 2 times, most recently from 1861ea9 to cfd5080 Compare December 13, 2024 13:06
Similar to ArcGIS MapsSDK for Unreal Engine
@bneukom bneukom force-pushed the bneukom/plugin_rename branch from cfd5080 to 9524043 Compare December 13, 2024 13:17
@bneukom bneukom merged commit 97d9464 into develop Dec 16, 2024
2 checks passed
@bneukom bneukom deleted the bneukom/plugin_rename branch December 16, 2024 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants