Skip to content

Conversation

@spike1292
Copy link
Member

Description / Motivation

Testing Details

  • Unit Test Added
  • Manual Test/Other (Please elaborate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

const componentRef = view.createComponent(rendering.componentImplementation);
componentRef.setInput('rendering', rendering.componentDefinition);
if (this._inputs) {
this._setComponentInputs(componentRef, this._inputs);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Within this _setComponentInputs there is an issue, I don't know why it is an issue now, maybe something changed with setInput in Angular 20, but when it tries to set an input that doesn't exist on the component placed in a placeholder, it will throw an error.

This now happens with a lot of components in DynamicRow because the DynamicRow will try to set the context input on all components placed in a column.

I think we can change the _setComponentInputs to something like this (untested):

  private _setComponentInputs(
    componentRef: ComponentRef<unknown>,
    inputs: { [key: string]: unknown }
  ) {
    Object.entries(inputs).forEach(([input, inputValue]) => {
      // Only set an input if it exists on the component
      if (input in componentRef) {
        componentRef.setInput(input, inputValue)
      }
    });
  }

related error

NG0303: Can't set value of the 'context' input on the '_MemberGetMemberWidgetComponent' component. Make sure that the 'context' property is declared as an input using the input() or model() function or the @Input() decorator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants