Minor Updates #20
Open
Minor Updates #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updating fork with latest from original branch.
Contributor
Author
|
Hold off on this one for now... I'm having issues deleting the |
spike1292
requested changes
Mar 9, 2018
Member
spike1292
left a comment
spike1292
left a comment
There was a problem hiding this comment.
‘rm -rf’ doesnt work on Windows that’s why we are using rimraf. You could add it to devDependencies. I have rimraf installed globally so that probably I don’t see this issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did not have
rimrafdefined, so I changed instances of it torm -rfin thepackage.jsonfile.I also saw
tsccomplaining about missing whitespace inmain-page.ts, so I fixed that, as well.