Skip to content

Fix workflow artifact upload paths missing "X" in EssentialsX addon jar names#6462

Merged
JRoy merged 3 commits into2.xfrom
copilot/update-workflows-for-artifact-upload
Mar 10, 2026
Merged

Fix workflow artifact upload paths missing "X" in EssentialsX addon jar names#6462
JRoy merged 3 commits into2.xfrom
copilot/update-workflows-for-artifact-upload

Conversation

Copy link
Contributor

Copilot AI commented Mar 9, 2026

Information

Workflow artifact upload steps referenced incorrect jar filenames — all addon jars are built as EssentialsX{Addon}-*.jar (e.g. EssentialsXChat, EssentialsXProtect) because project names in settings.gradle.kts are all prefixed with EssentialsX, and archivesName is set to project.name. The upload globs were missing the X, causing every per-module direct upload to fail to find its target file.

Details

Proposed fix:
Update all per-module archive: false upload step paths in both build-pr.yml and build-master.yml to use the correct EssentialsX-prefixed names:

Before After
jars/EssentialsAntiBuild-*.jar jars/EssentialsXAntiBuild-*.jar
jars/EssentialsChat-*.jar jars/EssentialsXChat-*.jar
jars/EssentialsDiscord-*.jar jars/EssentialsXDiscord-*.jar
jars/EssentialsDiscordLink-*.jar jars/EssentialsXDiscordLink-*.jar
jars/EssentialsGeoIP-*.jar jars/EssentialsXGeoIP-*.jar
jars/EssentialsProtect-*.jar jars/EssentialsXProtect-*.jar
jars/EssentialsSpawn-*.jar jars/EssentialsXSpawn-*.jar
jars/EssentialsXMPP-*.jar jars/EssentialsXXMPP-*.jar

The Javadoc cp paths in build-master.yml reference filesystem directory names (which don't include X) and remain correct as-is.

Environments tested:

OS: N/A (CI workflow change only)

Java version: N/A

  • Most recent Paper version (1.XX.Y, git-Paper-BUILD)
  • CraftBukkit/Spigot/Paper 1.12.2
  • CraftBukkit 1.8.8

Demonstration:

N/A — the incorrect globs would silently produce no artifact (or an error) for each addon module on every workflow run using archive: false.

Original prompt

https://github.blog/changelog/2026-02-26-github-actions-now-supports-uploading-and-downloading-non-zipped-artifacts/

update our workflows to use this rather than zipping (still provide the zip but also individually upload


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

…ividual jar uploads

Co-authored-by: JRoy <10731363+JRoy@users.noreply.github.com>
Copilot AI changed the title [WIP] Update workflows to support non-zipped artifact uploads Use upload-artifact@v7 for non-zipped individual jar artifacts Mar 9, 2026
Copilot finished work on behalf of JRoy March 9, 2026 23:22
@JRoy JRoy marked this pull request as ready for review March 9, 2026 23:22
Copilot AI changed the title Use upload-artifact@v7 for non-zipped individual jar artifacts Use upload-artifact@v7 for non-zipped per-jar artifact uploads Mar 9, 2026
Copilot finished work on behalf of JRoy March 9, 2026 23:26
Co-authored-by: JRoy <10731363+JRoy@users.noreply.github.com>
Copilot AI changed the title Use upload-artifact@v7 for non-zipped per-jar artifact uploads Fix workflow artifact upload paths missing "X" in EssentialsX addon jar names Mar 9, 2026
Copilot finished work on behalf of JRoy March 9, 2026 23:32
@JRoy JRoy enabled auto-merge March 10, 2026 00:31
@JRoy JRoy added this pull request to the merge queue Mar 10, 2026
Merged via the queue into 2.x with commit 302653a Mar 10, 2026
2 checks passed
@JRoy JRoy deleted the copilot/update-workflows-for-artifact-upload branch March 10, 2026 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants