GH-959 Move warp contents from language files. #1172
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request successfully refactors the warp inventory configuration from language files into a dedicated warp-inventory.yml, which is a significant improvement for maintainability. The adoption of a repository pattern with asynchronous, transactional operations is a solid architectural choice. However, I've identified a few critical issues, including a race condition and a bug where changes are not persisted, which could lead to data inconsistency. My review provides detailed feedback and suggestions to address these problems by better utilizing the new repository pattern.
eternalcore-core/src/main/java/com/eternalcode/core/feature/warp/inventory/WarpInventory.java
Outdated
Show resolved
Hide resolved
...re/src/main/java/com/eternalcode/core/feature/warp/inventory/WarpInventoryConfigService.java
Show resolved
Hide resolved
...ode/core/configuration/migrations/Migration_0010_Move_WarpInventory_to_dedicated_config.java
Outdated
Show resolved
Hide resolved
...core-core/src/main/java/com/eternalcode/core/feature/warp/inventory/WarpInventoryConfig.java
Outdated
Show resolved
Hide resolved
...e/src/main/java/com/eternalcode/core/feature/warp/inventory/WarpInventoryRepositoryImpl.java
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| public Map<String, WarpInventoryItem> getItems() { | ||
| return new HashMap<>(this.items); |
| } | ||
|
|
||
| public void setItems(Map<String, WarpInventoryItem> items) { | ||
| if (items == null) { |
There was a problem hiding this comment.
Ja bym nie zakładał że coś wchodzi jako null
| import java.util.logging.Logger; | ||
|
|
||
| @Repository | ||
| class WarpInventoryRepositoryImpl implements WarpInventoryRepository { |
There was a problem hiding this comment.
Hm tutaj już trochę nadinżynieria
| } | ||
|
|
||
| public CompletableFuture<Void> removeWarp(String warpName) { | ||
| if (!this.warpSettings.autoAddNewWarps()) { |
There was a problem hiding this comment.
here maybe add check if the warp is in the inventory instead of checking the settings
| }); | ||
| } | ||
|
|
||
| private void performSlotShift(List<WarpInventoryItem> itemsToShift, int removedSlot) { |
There was a problem hiding this comment.
Maybe this nested method can be simplified and used inside of #shiftWarpItems() method instead of extracting it
| this.warpInventoryConfigService = warpInventoryConfigService; | ||
| } | ||
|
|
||
| public void openInventory(Player player) { |
There was a problem hiding this comment.
WarpInventory#openInventory is redundant. Cut it to open()
| }); | ||
| } | ||
|
|
||
| private void performSlotShift(List<WarpInventoryItem> itemsToShift, int removedSlot) { |
Fixes: GH-959