GH-577 Add TpaCommand to support ignored players #577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
P1otrulla
changed the title
vLuckyyy
approved these changes
Dec 10, 2023
imDMK
approved these changes
Dec 10, 2023
eternalcore-core/src/main/java/com/eternalcode/core/feature/teleport/request/TpaCommand.java
Outdated
Show resolved
Hide resolved
Rollczi
requested changes
Dec 10, 2023
| .notice(translation -> translation.tpa().tpaReceivedMessage()) | ||
| .placeholder("{PLAYER}", player.getName()) | ||
| .send(); | ||
| }); | ||
|
|
||
| this.requestService.createRequest(player.getUniqueId(), target.getUniqueId()); |
There was a problem hiding this comment.
I think you should create request when target is not ignored
There was a problem hiding this comment.
Powinieneś stworzyć requesta tylko wtedy kiedy target nie jest ignorowany.
Obecnie "zasłaniasz" wiadomość ale tak po za tym zawsze wysyłasz tpa requesta, co może być problematyczne jak ktoś wpisze /tpaaccet i nieświadomie zaakceptuje ostatniego "ignorowanego" requesta (a np. spodziewał się akceptacji starszego requesta którego widział na chat)
Kazaruma
approved these changes
Dec 10, 2023
vLuckyyy
approved these changes
Dec 10, 2023
Rollczi
reviewed
Dec 10, 2023
eternalcore-core/src/main/java/com/eternalcode/core/feature/teleport/request/TpaCommand.java
Outdated
Show resolved
Hide resolved
Rollczi
approved these changes
Dec 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All tested, smingen