GH-879 Prevent counting online players with vanish in %eternalcore_online% #887
Conversation
WalkthroughThe pull request modifies the Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
P1otrulla
changed the title
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (1)
eternalcore-core/src/main/java/com/eternalcode/core/placeholder/PlaceholdersSetup.java(2 hunks)
🔇 Additional comments (3)
eternalcore-core/src/main/java/com/eternalcode/core/placeholder/PlaceholdersSetup.java (3)
4-4: LGTM!The VanishService import is properly added.
22-28: Nice implementation!The stream filter cleanly excludes vanished players from the count. The code is easy to read and does exactly what the PR intended.
21-21: Verify dependency injection setupThe new VanishService parameter looks good, but let's make sure it's properly configured in the dependency injection system.
✅ Verification successful
DI setup looks good! ✨
The VanishService is properly set up with
@Serviceannotation and constructor injection, so it will work fine as a parameter in PlaceholdersSetup.🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Search for VanishService configuration in DI setup rg -l "VanishService.*@Component|@Component.*VanishService"Length of output: 61
Script:
#!/bin/bash # Find VanishService implementation fd -e java "VanishService" --exec rg -l "class.*implements.*VanishService|class.*VanishService.*implements" # Look for VanishService with common DI annotations rg -l "@(Component|Service|Configuration|Bean).*class.*Vanish|class.*Vanish.*@(Component|Service|Configuration|Bean)" # Search for VanishService bean configuration rg -l "VanishService.*bean|bean.*VanishService"Length of output: 277
Script:
#!/bin/bash # Find VanishService definition fd -e java "Vanish" # Look for vanish-related content rg -l -i "vanish" --type javaLength of output: 903
Script:
#!/bin/bash # Check VanishService content cat eternalcore-core/src/main/java/com/eternalcode/core/feature/vanish/VanishService.java # Look for service initialization patterns rg -A 5 "new VanishService" --type javaLength of output: 1188
eternalcore-core/src/main/java/com/eternalcode/core/placeholder/PlaceholdersSetup.java
Show resolved
Hide resolved
vLuckyyy
changed the title
No description provided.