-
Notifications
You must be signed in to change notification settings - Fork 1
deno_generate idea #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Hello @EthanThatOneKid just checking in. I've stopped using // deno.json
{
"tasks": {
"generate": "deno run -A npm:peggy@3 css.pegjs && deno run -A npm:some-other-package"
}
}...to be what I reach for most often instead of another tool that I'd just end up putting in Point being: I'm no longer using https://github.com/jcbhmr/deno_generate and thus plan on deleting my fork soon. I'd love to see some of the ideas presented in the PR merged back into this original repo but if not that's ok. Would love to see an explicit ✅/❌ 😊 psst! the https://deno.land/x/deno_generate name is still available for you to claim; I didn't claim it lol |
Hello! 👋
This is a friendly PR to upstream some ideas and things that I had to improve the
deno_generatesubcommand. You should not feel obliged to merge this Pull Request if you don't want to ❤️This PR would:
deno installthe app don't have to set a custom name; they justdeno install -A https://deno.land/x/deno_generate/main.tsand viola! Now they have adeno_generatecommand ready to go!main.tsscript. This means removing a bunch of other stuff too...node:Node.js APIs instead of Deno's std. This is controversial. Can be reverted idcStill support for thecommented it out because idk didn't think it was needed for a proof-of-concept thing; you can add it back in idc//go:generate -command myalias deno run -Afeature//go:generate. idk if this was a good idea or not. probably not. this was a side-effect of me just completely gutting the projectdeno testbeing run in ci)It boils down to: this project is quite large for what it does. It just loops over some
//deno:generate (\S+) (.*)stuff and runs the commands. This PR attempts to trim the fat and focus on that. imo the main.ts is much more understandable as a single file unit instead of 10 files scattered over 3 folders. but that's me.if merged you probs wanna do a squash merge to ignore all my terrible commit messages lol
btw feel free to make edits to this branch:
again to reiterate: this is an idea that you don't have to merge or even entertain if you dont want. im perfectly OK with continuing to toy around with my own fork 😊 this is just a friendly "here's an idea" pr