Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validator set precompile #118

Open
wants to merge 16 commits into
base: develop
Choose a base branch
from

Conversation

igorcrevar
Copy link

Description

Validator set pre-compile will provide two functions to smart contracts:

  • isValidator(address) bool
  • hasQuorum(address[]) bool

Precompile will work only for polybft consensus and will not provide any of those two functions at genesis time

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Breaking changes

Please complete this section if any breaking changes have been made, otherwise delete it

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

Documentation update

I think we should add this to the docs

@igorcrevar igorcrevar added the feature New feature label Feb 14, 2024
@igorcrevar igorcrevar self-assigned this Feb 14, 2024
@igorcrevar igorcrevar force-pushed the feature/validator_set_precompile branch 3 times, most recently from 1614ad6 to 543b51e Compare February 19, 2024 08:49
@igorcrevar igorcrevar marked this pull request as ready for review February 19, 2024 08:53
@igorcrevar igorcrevar force-pushed the feature/validator_set_precompile branch from 942fd54 to 3bdb0ef Compare February 19, 2024 11:36
@igorcrevar igorcrevar force-pushed the feature/validator_set_precompile branch 2 times, most recently from 99b2cf9 to 09381e0 Compare March 1, 2024 09:10
goran-ethernal
goran-ethernal previously approved these changes Mar 1, 2024
@goran-ethernal goran-ethernal force-pushed the feature/validator_set_precompile branch from 09381e0 to f486ac4 Compare March 6, 2024 08:18
@oliverbundalo oliverbundalo added the do-not-merge Do not merge this PR until label is removed label Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge Do not merge this PR until label is removed feature New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants