Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement analyze methods send transaction accounts sign transaction send private transaction #166

Conversation

novosandara
Copy link

@novosandara novosandara commented Mar 26, 2024

Description

Please provide a detailed description of what was done in this PR

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Breaking changes

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

Manual tests

Documentation update

Additional comments

@novosandara novosandara marked this pull request as ready for review April 1, 2024 22:58
consensus/polybft/wallet/account.go Outdated Show resolved Hide resolved
jsonrpc/eth_endpoint.go Outdated Show resolved Hide resolved
jsonrpc/eth_txpool_test.go Outdated Show resolved Hide resolved
txpool/txpool.go Outdated Show resolved Hide resolved
@@ -137,7 +138,7 @@ type header struct {
BaseFee argUint64 `json:"baseFeePerGas,omitempty"`
}

type accessListResult struct {
type AccessListResult struct {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you need it exported?

jsonrpc/mocks_test.go Show resolved Hide resolved
@goran-ethernal goran-ethernal added the do-not-merge Do not merge this PR until label is removed label Apr 24, 2024
@goran-ethernal goran-ethernal marked this pull request as draft April 24, 2024 07:20
@goran-ethernal goran-ethernal deleted the Implement-Analyze-Methods-sendTransaction_accounts_signTransaction_sendPrivateTransaction branch October 29, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge Do not merge this PR until label is removed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants