Open
Conversation
Collaborator
Author
|
I think something went wrong with rebasing. The code is currently in one commit, not 7. |
|
Hi MegaChriz ,
All the tamper plugins are working well as expected. Here is the example yml file I used, Let me know your comments. Thanks. |
Collaborator
Author
|
Thanks for testing so far! If you like, maybe you want to test the following plugins as well, because these are more complicated and thus more likely to not work correctly:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem/Motivation
This connects Tamper with Migrate process plugins. This way Tamper plugins can be applied in migrations. And it is useful while developing the process plugin UI. We can see how Tamper forms will appear in this UI.
I'm not sure however if this code should be part of Feeds Migrate, as the code doesn't depend on any other code in Feeds Migrate. It can work with Migrate on its own.
Proposed solution
The solution provides the following:
I've tested the code with one Tamper plugin - Find replace regex - and found that that one works. There is however no test coverage yet, so I'm not sure if all plugins work correctly. Some Tamper plugins expect an array as input for example, other plugins throw exceptions to indicate an item should be skipped.
Example/QA
Example for applying the tamper plugin "Find replace regex":