Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example Applications - Bug fixes and enhancements for tx_waveforms and tx_samples_from_file #707

Conversation

joelkeeling
Copy link
Contributor

@joelkeeling joelkeeling commented Oct 4, 2023

Pull Request Details

Description

  • Fixed bug in channel handling in tx_waveforms so now all available channels can be used
  • Fixed bug in channel handling in tx_samples_from_file so now all available channels can be used
  • Added support for the 'power' argument in tx_samples_from_file so that it matched other example applications
  • Added support for multiple channels with the 'channels' argument in tx_samples_from_file so that it matched other example applications

Related Issues

Fixes #705
Fixes #706

Testing Done

This should not affect the core UHD library as these changes only apply to the example applications.
Re-ran both examples applications multiple times on a hardware setup that included an X410 and SC2430 SCM. Tested all input arguments that were added or modified.

Checklist

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project. See CODING.md.
  • (Not applicable) I have updated the documentation accordingly.
  • (Not applicable) I have added tests to cover my changes, and all previous tests pass.
  • (Not applicable) I have checked all compat numbers if they need updating (FPGA compat,
    MPM compat, noc_shell, specific RFNoC block, ...)

… 1 and higher could not be configured correctly. Added the 'power' argument. Added support for multiple channels.
…ckwards compatibility. Added additional error checking. Changed help descriptions to match other example apps.
@github-actions
Copy link

github-actions bot commented Oct 4, 2023

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@joelkeeling
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@joelkeeling
Copy link
Contributor Author

recheck

@atomita-ni atomita-ni closed this Dec 4, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Dec 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
1 participant