Conversation
Preview available
|
|
@egeakman I don't know if the component and styling changes make any sense. Would you mind taking a look when you have the time before all the content is ready from the team? |
|
@hypha I think it looks great! The ribbon placement looks better than last year I think. And huuuuuuge hugs 🤗 for converting the sponsor components to Astro! |
968bcda to
1ee573e
Compare
Thanks for the lightning-fast review, @egeakman! The ribbon was overlapping with the text last year, which was bugging me. That should be sorted now. I might play with tweaking it further, e.g. making it narrower, though it’s not a priority. For the sponsor astro component, I’m not sure of the best way to handle the ribbon svg. I also lack the context for why the tier specific ribbon colours were defined in the tailwind config. But for now, I’ve separated the svg out so at least sponsor-tiers is cleaner. Side note: I retained the filenames for now, but having multiple similar ones like sponsor-tier.astro, sponsor-tiers.astro, and sponsors.astro might get confusing. Maybe we can revisit the naming later. |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Co-authored-by: Mia Bajić <38294198+clytaemnestra@users.noreply.github.com>
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
|
I went through the PR again to check it against the approved numbers, and everything LGTM! Given that the budget has been approved, I think we can merge it 🚀 |


Uh oh!
There was an error while loading. Please reload this page.