Conversation
Co-authored-by: Mia Bajić <38294198+clytaemnestra@users.noreply.github.com>
Co-authored-by: Mia Bajić <38294198+clytaemnestra@users.noreply.github.com>
for more information, see https://pre-commit.ci
Co-authored-by: Mia Bajić <38294198+clytaemnestra@users.noreply.github.com>
for more information, see https://pre-commit.ci
Co-authored-by: Mia Bajić <38294198+clytaemnestra@users.noreply.github.com>
Co-authored-by: Mia Bajić <38294198+clytaemnestra@users.noreply.github.com>
Co-authored-by: Mia Bajić <38294198+clytaemnestra@users.noreply.github.com>
Co-authored-by: Mia Bajić <38294198+clytaemnestra@users.noreply.github.com>
for more information, see https://pre-commit.ci
6e129f3 to
9385918
Compare
for more information, see https://pre-commit.ci
Preview available
|
There was a problem hiding this comment.
Copilot reviewed 6 out of 9 changed files in this pull request and generated no comments.
Files not reviewed (3)
- src/components/footer.astro: Language not supported
- src/components/social/SocialSubscribe.astro: Language not supported
- src/pages/index.astro: Language not supported
|
Feels like the social buttons are in reverse order. Don't you want to put LinkedIn first and X last? |
Thanks for the suggestion, swapped ✅ |
nikoshell
left a comment
There was a problem hiding this comment.
PR is ok.
Should we prepare common solution for icons before we will use it every where?
Should we introduce right now non static sections without proper api configs and security standards.
Co-authored-by: Nikoś <nikoshell20@protonmail.com>
There was a problem hiding this comment.
Huge footer links corresponds to all previous years. If we are not introducing new design I will stay with big one.
|
We agreed with @nikoshell to keep the PR as a reference, but first to implement security standards and then to reimplement this section. |
Changelog
Layout tests
4k
Phone
🖼️ Preview available 🖼️ : https://ep-website--1070.org.readthedocs.build/