Conversation
Member
Preview available
|
clytaemnestra
approved these changes
Jun 25, 2025
Comment on lines
+60
to
+71
| const sponsorsWithJobs = sponsors | ||
| .filter((sponsor) => sponsor.data.jobs && sponsor.data.jobs.length > 0) | ||
| .sort((a, b) => { | ||
| const aTierIndex = tiers.indexOf(a.data.tier as typeof tiers[number]); | ||
| const bTierIndex = tiers.indexOf(b.data.tier as typeof tiers[number]); | ||
|
|
||
| // If tier not found in array, put it at the end | ||
| const aIndex = aTierIndex === -1 ? tiers.length : aTierIndex; | ||
| const bIndex = bTierIndex === -1 ? tiers.length : bTierIndex; | ||
|
|
||
| return aIndex - bIndex; | ||
| }); |
Contributor
There was a problem hiding this comment.
Not a JS developer, but this looks complicated to me - I think we can assume that each sponsor has a tier assigned. Otherwise we wouldn't be able to create one, no?
In that case, I think something as simple as sponsors.filter((s) => s.data.jobs.length).sort((a, b) => tiers.indexOf(a.data.tier) - tiers.indexOf(b.data.tier)); might work (I didn't try to run it, I'm guessing here) and is more readable, no?
Contributor
Author
There was a problem hiding this comment.
We care only about sponsors with tier which allows to job posts. Array of tiers is shorter then all tiers that we have.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.