Make accordion styling as a component#996
Merged
Conversation
Contributor
Preview available
|
Member
|
Thanks for the PR @hypha ❤️ This works but I would prefer using Astro wherever we can. Could we use Astro if it's not too much work? What do you think? |
Contributor
Author
|
@egeakman sure! Since there is no rush for this, I'll try next week! Good point! <3 |
Contributor
Author
|
@egeakman I've converted it to an astro component (I hope!) Would you mind reviewing it whenever you got the time? <3 |
Member
|
I'd like to merge #1024 first, so we can test this! Thank you Raquel ❤️ |
Contributor
Author
Exactly what I thought too! I will definitely add the use case to test page once it is merged! <3 |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working on the accordion styling for session types in PR #989, it became clear that extracting it into a reusable component would make things easier for the team.