202402/desy 311 update #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobertRosca
assigned takluyver and JamesWrigley and unassigned takluyver and JamesWrigley
|
View preview here - https://European-XFEL.github.io/environments/pr/49 (build for b89c989) Preview removed on merge/PR close with 3d998bd |
JamesWrigley
requested changes
Nov 7, 2024
|
Thanks! I agree with James about the docs, otherwise LGTM. (Normally I'd hesitate to jump several versions of matplotlib in an existing environment - that's used enough for people to hit regressions & removals. But I assume it's necessary to keep compatibility with the widgets stuff) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Syncs 202402 environment with package versions used in DESY's mamba/3.11 environment which is now the default environment for max-jhub.
Already performed the update on the environment, looks like widgets and interactive matplotlib plots via
%matplotlib widgetboth work.