Skip to content

AGENTS: Add infra-blocked escape hatch + timebox#166

Merged
PrzemyslawKlys merged 1 commit intomasterfrom
codex/agents-playbook-streamline
Feb 9, 2026
Merged

AGENTS: Add infra-blocked escape hatch + timebox#166
PrzemyslawKlys merged 1 commit intomasterfrom
codex/agents-playbook-streamline

Conversation

@PrzemyslawKlys
Copy link
Member

Update AGENTS.md to keep the PR-handling loop strict on real blockers, but avoid infinite churn when CI is non-actionable.

  • Add explicit classification of CI failures: actionable vs infra-blocked (billing/spend limit, runner capacity, third-party premium/auth gating, outages)
  • Add infra-blocked escape hatch: record once (TODO/issue + link) then move on
  • Add timebox: 2 iterations or 60 minutes unless maintainers request continued iteration

@intelligencex-review
Copy link

intelligencex-review bot commented Feb 9, 2026

IntelligenceX Review

Reviewing PR #166: AGENTS: Add infra-blocked escape hatch + timebox
Reviewed commit: 9b45513

Merge blockers: items in Todo List ✅ and Critical Issues ⚠️ sections (if present). Other Issues 🧯 are suggestions.

Summary 📝

Good update: the actionable vs infra-blocked split and the escape hatch reduce pointless churn when CI is non-actionable. Main concern is internal consistency: the loop currently has two “move on” rules (step 7 and step 9) that can conflict and invite misinterpretation.

Todo List ✅

  • Make the PR Handling Loop “move on” criteria single-source-of-truth (avoid duplicated/conflicting rules between steps 7 and 9).
    Rationale: ambiguous process docs lead to inconsistent execution and missed blockers.

Critical Issues ⚠️

  • The PR Handling Loop has overlapping/duplicated “move on” guidance (step 7 introduces a move-on condition; step 9 restates it with additional conditions).
    Rationale: conflicting instructions are correctness issues for the repo’s automation/process and will cause agents to behave unpredictably.

Other Issues 🧯

  • Consider explicitly stating that “infra-blocked” does not include flaky tests or intermittent failures (those are usually actionable via retries/quarantines).
    Rationale: reduces misclassification where a real signal gets ignored.
  • The escape hatch mentions “sync explicit bot checklist items into TODO.md” but doesn’t specify the minimal required fields (PR link, run link, timestamp, classification).
    Rationale: consistent tracking improves maintainability and prevents repeated rediscovery.

Tests / Coverage 🧪

None (docs-only change).

Next Steps 🚀

  • Refactor the PR Handling Loop so only one step defines the “move on” decision (preferably step 9), and step 7 only defines how to record/track infra-blocked status.

Static Analysis Policy 🧭

  • Config mode: respect
  • Packs: All Essentials (50)
  • Rules: 53 enabled
  • Rule list display: up to 10 items per section
  • Enabled rules preview: CA2000 (Dispose objects before losing scope), CA1062 (Validate arguments of public methods), SA1600 (Elements should be documented), CA1016 (Mark assemblies with assembly version), CA1018 (Mark attributes with AttributeUsageAttribute), CA1041 (Provide ObsoleteAttribute message), CA1047 (Do not declare protected member in sealed type), CA1050 (Declare types in namespaces), CA1061 (Do not hide base class methods), CA1067 (Override Object.Equals(object) when implementing IEquatable<T>) (truncated)
  • Result files: 2 input patterns, 1 matched, 1 parsed, 0 failed
  • Status: pass
  • Rule outcomes: 0 with findings, 53 clean
  • Failing rules: none
  • Clean rules: CA2000 (Dispose objects before losing scope), CA1062 (Validate arguments of public methods), SA1600 (Elements should be documented), CA1016 (Mark assemblies with assembly version), CA1018 (Mark attributes with AttributeUsageAttribute), CA1041 (Provide ObsoleteAttribute message), CA1047 (Do not declare protected member in sealed type), CA1050 (Declare types in namespaces), CA1061 (Do not hide base class methods), CA1067 (Override Object.Equals(object) when implementing IEquatable<T>) (truncated)
  • Outside-pack rules: none

Static Analysis 🔎

  • Findings: 0 (no issues at or above configured severity)

Model & Usage 🤖

  • Model: gpt-5.3-codex
  • Length: medium
  • Mode: inline
  • Reasoning: not configured
  • Usage: 5h limit: 96% remaining | weekly limit: 55% remaining | code review weekly limit: 100% remaining | credits: 0

8. Timebox rule (to prevent endless bot-chasing):
- Default limit: 2 full iterations of the bot loop or 60 minutes per PR (whichever comes first).
- If still blocked after the timebox, post a short status summary (what’s fixed, what’s left, why it’s hard) and wait for maintainer direction to continue.
9. Only move on to the next PR when the current PR has no remaining todo/critical blockers (or maintainers explicitly decide to accept the risk, or the PR is infra-blocked and recorded per step 7).

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment: This duplicates/conflicts with step 7’s “move on” rule; make step 9 the only “move on” rule and keep step 7 purely as the infra-blocked procedure to avoid ambiguity.

Suggested change
9. Only move on to the next PR when the current PR has no remaining todo/critical blockers (or maintainers explicitly decide to accept the risk, or the PR is infra-blocked and recorded per step 7).
9. Only move on to the next PR when the current PR has no remaining todo/critical blockers (or maintainers explicitly decide to accept the risk, or the PR is infra-blocked and recorded per step 7).

Run: `gh pr checks <num> --repo EvotecIT/IntelligenceX`
If the bot posts new todo/critical items, repeat.
7. Only move on to the next PR when the current PR has no remaining todo/critical blockers (or maintainers explicitly decide to accept the risk).
7. Infra-blocked escape hatch:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment: Step 7 currently both defines a procedure and includes “Move on…” semantics; suggest removing the “Move on…” sentence here and letting step 9 be the single decision point for moving on.

@PrzemyslawKlys PrzemyslawKlys merged commit 64f3cc9 into master Feb 9, 2026
9 of 12 checks passed
@PrzemyslawKlys PrzemyslawKlys deleted the codex/agents-playbook-streamline branch February 9, 2026 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant