CI: don't fail when CodeQL code scanning is disabled#170
CI: don't fail when CodeQL code scanning is disabled#170PrzemyslawKlys merged 1 commit intomasterfrom
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e1421589e6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| uses: github/codeql-action/analyze@v3 | ||
| # Repo settings can disable code scanning (e.g., private repos without Code Security enabled). | ||
| # Keep CI green while still attempting analysis when available. | ||
| continue-on-error: true |
There was a problem hiding this comment.
Setting continue-on-error: true here makes the CodeQL job pass even when analysis genuinely fails (for example extractor/query execution/upload errors), so branch protection can report a green security check while no scan results were produced. This change was meant to tolerate the specific "code scanning disabled" case, but it currently suppresses all analyze failures in enabled repositories as well, which weakens CI/security signal reliability.
Useful? React with 👍 / 👎.
IntelligenceX ReviewReviewing PR #170: CI: don't fail when CodeQL code scanning is disabled Merge blockers: items in Todo List ✅ and Critical Issues Workflow-only changes detected (1 workflow file). Head SHA: e142158. Review skipped to avoid self-modifying workflow runs. Set allowWorkflowChanges or REVIEW_ALLOW_WORKFLOW_CHANGES=true to override. Model & Usage 🤖
|
1 participant
CodeQL analysis jobs can fail on repos where code scanning isn't enabled (common for private repos without Code Security). Mark the analyze step as non-fatal so CI remains usable.