Fuzz Metadata::print() with nullptr parameter #2663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Leaving as draft for now, because there are some known bugs in |
|
LGTM. |
Codecov Report
@@ Coverage Diff @@
## main #2663 +/- ##
=======================================
Coverage 63.92% 63.92%
=======================================
Files 103 103
Lines 22306 22306
Branches 10795 10795
=======================================
Hits 14259 14259
Misses 5826 5826
Partials 2221 2221 |
kevinbackhouse
force-pushed
the
fuzz-metadatum-print-nullptr
branch
from
7a0380e
to
469c76c
Compare
|
At the risk of sounding like a broken record: the number/size of current CI jobs is unwieldy and unsustainable. |
kmilos
approved these changes
Jun 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should prevent issues like #2638 and #2649 from happening again.