Check if the metadata is NULL

[kevinbackhouse]

Fixes: #2638, #2649

[kevinbackhouse]

I've converted this to draft because I'd like to merge #2664 first.

[kevinbackhouse]

@Mergifyio backport 0.28.x

[mergify]

backport 0.28.x

✅ Backports have been created

• #2669 Check if the metadata is NULL (backport #2665) has been created for branch 0.28.x

[ghost]

👇 Click on the image for a new way to code review

Legend

[codecov]

Codecov Report

Merging #2665 (1119a68) into main (6b186a4) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main    #2665   +/-   ##
=======================================
  Coverage   63.92%   63.92%           
=======================================
  Files         103      103           
  Lines       22306    22306           
  Branches    10795    10795           
=======================================
  Hits        14259    14259           
  Misses       5826     5826           
  Partials     2221     2221           

Impacted Files	Coverage Δ
src/nikonmn_int.cpp	61.20% <0.00%> (ø)
src/sonymn_int.cpp	79.90% <0.00%> (ø)

[postscript-dev]

@kevinbackhouse
Thanks for creating this PR. I started to look at this but your work saves me some time!

I reviewed all the tags and, as far as I could see, the only guards needed were in src/nikonmn_int.cpp and src/sonymn_int.cpp.

For your PR, in src/sonymn_int.cpp, I would also add || !metadata guards for functions that use:

1. static auto getModel(const ExifData* metadata, std::string& val)
2. static auto getAFAreaModeSetting(const ExifData* metadata, uint32_t& val)
3. static auto getMetaVersion(const ExifData* metadata, std::string& val)
4. static auto getFocusMode2(const ExifData* metadata, uint32_t& val)

[kevinbackhouse]

Good catch @postscript-dev! I've updated #2664 to catch those cases too. And I've added a second commit here with the extra fixes.