Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix preprocessor warnings about undefined _MSVC_LANG #2676

Merged
merged 1 commit into from
Jul 3, 2023
Merged

Fix preprocessor warnings about undefined _MSVC_LANG #2676

merged 1 commit into from
Jul 3, 2023

Commits on Jul 3, 2023

  1. Fix preprocessor warnings about undefined _MSVC_LANG 

    Stricter compiler/settings, such as found during a build
on FreeBSD with clang 14, issue warnings of the kind below.

/usr/local/include/exiv2/value.hpp:1272:31: warning: '_MSVC_LANG' is not defined, evaluates to 0 [-Wundef]

Fix: Guard use of _MSVC_LANG by a check.

Personally, I found that MSVC has several feature-specific
checks in predefined macros which might allow for one
standards-based check that matches GCC/clang/MSVC rather than the
split check for C++ standard and MSVC language version settings.

See https://en.cppreference.com/w/cpp/feature_test

I am not building Exiv2 on MSVC, so I cannot test/suggest
anything here.
    @mandree
    mandree committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    2f2a926 View commit details
    Browse the repository at this point in the history