Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: run nightly workflow really nightly only #2741

Merged
merged 1 commit into from
Aug 8, 2023
Merged

Conversation

kmilos
Copy link
Collaborator

@kmilos kmilos commented Aug 8, 2023

The number of CI jobs on push/PR is simply unsustainable.

@ghost
Copy link

ghost commented Aug 8, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@kmilos kmilos requested a review from neheb August 8, 2023 14:08
@codecov
Copy link

codecov bot commented Aug 8, 2023

Codecov Report

Merging #2741 (cf8a24a) into main (4dfb781) will decrease coverage by 0.01%.
Report is 22 commits behind head on main.
The diff coverage is 55.55%.

❗ Current head cf8a24a differs from pull request most recent head 5144d96. Consider uploading reports for the commit 5144d96 to get more accurate results

@@            Coverage Diff             @@
##             main    #2741      +/-   ##
==========================================
- Coverage   63.91%   63.90%   -0.01%     
==========================================
  Files         103      103              
  Lines       22313    22313              
  Branches    10804    10805       +1     
==========================================
- Hits        14261    14260       -1     
- Misses       5828     5831       +3     
+ Partials     2224     2222       -2     
Files Changed Coverage Δ
src/futils.cpp 73.09% <ø> (ø)
src/http.cpp 0.00% <0.00%> (ø)
src/makernote_int.cpp 65.91% <ø> (ø)
src/basicio.cpp 50.46% <36.36%> (-0.06%) ⬇️
include/exiv2/slice.hpp 90.56% <100.00%> (ø)
src/convert.cpp 52.35% <100.00%> (ø)

neheb
neheb previously approved these changes Aug 8, 2023
@mergify mergify bot dismissed neheb’s stale review August 8, 2023 14:21

Pull request has been modified.

@neheb
Copy link
Collaborator

neheb commented Aug 8, 2023

While we’re on the topic, these seem to be using make. Ninja is faster than GNU Make, specifically with CMake. I think I measured an 8% average speed up in my testing elsewhere.

@kmilos
Copy link
Collaborator Author

kmilos commented Aug 8, 2023

Ok, let's give it a go, I'll trigger it manually now to check.

@kmilos kmilos force-pushed the kmilos/ci_nightly branch 3 times, most recently from 392f106 to cf8a24a Compare August 8, 2023 15:21
@kmilos
Copy link
Collaborator Author

kmilos commented Aug 8, 2023

Sheeesh...

Ok, should be good to go now: https://github.com/Exiv2/exiv2/actions/runs/5799156458

@neheb neheb merged commit 853044f into main Aug 8, 2023
110 checks passed
@neheb neheb deleted the kmilos/ci_nightly branch August 8, 2023 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants