Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed compile error for epsimage.cpp #2944

Merged
merged 1 commit into from
Apr 2, 2024
Merged

Fixed compile error for epsimage.cpp #2944

merged 1 commit into from
Apr 2, 2024

Conversation

wmanth
Copy link
Contributor

@wmanth wmanth commented Apr 2, 2024

This error pops up when compiling the library with a different (external) build system, e.g. as part of a Swift package and the DEBUG flag is set.
It won't show up when building via CMake as the flag won't be set.

kmilos
kmilos previously approved these changes Apr 2, 2024
Copy link
Collaborator

@kmilos kmilos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@kmilos
Copy link
Collaborator

kmilos commented Apr 2, 2024

You mind fixing the clang-format failure while at it please?

Copy link

codecov bot commented Apr 2, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 64.62%. Comparing base (66297f2) to head (1834845).

Files Patch % Lines
src/epsimage.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2944   +/-   ##
=======================================
  Coverage   64.62%   64.62%           
=======================================
  Files         104      104           
  Lines       22239    22239           
  Branches    10911    10911           
=======================================
  Hits        14371    14371           
  Misses       5626     5626           
  Partials     2242     2242           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mergify mergify bot dismissed kmilos’s stale review April 2, 2024 16:59

Pull request has been modified.

@kmilos kmilos merged commit 6f42d99 into Exiv2:main Apr 2, 2024
58 checks passed
@kmilos
Copy link
Collaborator

kmilos commented Apr 2, 2024

Thank you for your contribution!

@kmilos kmilos added the build label Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants