change print of Exif.Canon.SerialNumber (backport #2806) #2971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
kmilos
added
the
makerNote
|
@mergify rebase |
❌ Unable to rebase: user
|
kmilos
approved these changes
May 17, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reference: #2792
In general serial number is just printed as decimal. Exception for EOS D30, where higher bytes are printed as hex, lower bytes as decimal, the format, which was used for all Canon devices before this change.
Output is now aligned with Canon Photo Digital Professional 4 (except leading zeros). A few exceptions, where the images have two entries in Exif.Canon.SerialNumber (which looks strange): then Canon Photo Digital Professional shows only one number.
As print0x000c was also used for 0x000a, new function print0x000a as copy from old print0x000c.
This is an automatic backport of pull request #2806 done by Mergify.